[Webkit-unassigned] [Bug 214180] [GTK] MiniBrowser: title of back-forward menu items needs to be truncated when it's too large

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 10 05:38:26 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=214180

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #403956|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 403956
  --> https://bugs.webkit.org/attachment.cgi?id=403956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403956&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:235
> +            displayTitle[MAX_TITLE - 1] = '.';

I would use an actual ellipsis character (“…”, U+2026) which in
UTF-8 is the sequence of bytes 0xE2, 0x80, 0xA6:

  displayTitle[MAX_TITLE - 3] = 0xE2;
  displayTitle[MAX_TITLE - 2] = 0x80;
  displayTitle[MAX_TITLE - 1] = 0xA6;

��️

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200710/07d8075c/attachment.htm>


More information about the webkit-unassigned mailing list