[Webkit-unassigned] [Bug 214132] New: [MSE][GStreamer] Remove m_appendPipelinesMap
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 9 05:13:32 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=214132
Bug ID: 214132
Summary: [MSE][GStreamer] Remove m_appendPipelinesMap
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebKitGTK
Assignee: webkit-unassigned at lists.webkit.org
Reporter: aboya at igalia.com
CC: bugs-noreply at webkitgtk.org
m_appendPipelinesMap was owned by MediaPlayerPrivateGStreamerMSE but
was only used by MediaPlayerPrivateGStreamerMSE to clear it during
destruction, while the other uses were in
MediaSourceClientGStreamerMSE.
After analysis, it was found keeping a HashMap of AppendPipelines is not
necessary. An AppendPipeline only needs to be used by the SourceBuffer
receiving the muxed data: making AppendPipeline a member of
SourceBufferPrivateGStreamer reflects this dependency in a much
clearer way. No need for a HashMap of AppendPipeline's.
Moreso, there are no other users of AppendPipeline, which means
AppendPipeline doesn't need to be ref counted. This patch removes that
feature, using std::unique_ptr<AppendPipeline> for ownership instead.
This patch is a refactor: it doesn't introduce behavior changes and
it's covered by existing tests.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200709/331ea4cb/attachment.htm>
More information about the webkit-unassigned
mailing list