[Webkit-unassigned] [Bug 213949] Compile-time enable (but leave disabled at runtime by default) date/time input types on macOS to allow testing of cross platform (e.g. DOM) aspects of the controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213949

--- Comment #7 from Sam Weinig <sam at webkit.org> ---
(In reply to Sam Weinig from comment #6)
> (In reply to Sam Weinig from comment #5)
> > (In reply to Sam Weinig from comment #4)
> > > (In reply to Darin Adler from comment #3)
> > > > Seems like an obviously good idea.
> > > > 
> > > > I seem to recall that we made the decision to compile them out long ago when
> > > > we couldn’t thoroughly and completely disable such feature at runtime.
> > > 
> > > Hm, I am not sure if that is still a problem. It seems like the runtime
> > > checks when creating the InputType subclass should be enough. But I will
> > > keep this in mind.
> > > 
> > 
> > Hm, I wonder if the issue was with default style sheet. Indeed, enabling the
> > macro, but disabling the runtime feature for, for instance,
> > ENABLE_INPUT_TYPE_DATE, will still have this added to html.css:
> > 
> > input[type="date"] {
> >     align-items: center;
> >     -webkit-appearance: menulist-button;
> >     display: -webkit-inline-flex;
> >     overflow: hidden;
> > #if !(defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY)
> >     width: 10em;
> > #endif
> > }
> > 
> > which is likely observable. I am not sure how big a deal this would be in
> > practice.
> 
> If it is an issue, seems like a good time to make see what it would take to
> allow runtime settings to control what is in the user agent style sheet.

Now I am just talking to myself, but it seems like UserAgentStyle::ensureDefaultStyleSheetsForElement() allows for this already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200704/df6d5b43/attachment-0001.htm>