[Webkit-unassigned] [Bug 213954] [SOUP] Add support for HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213954

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 403520
  --> https://bugs.webkit.org/attachment.cgi?id=403520
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=403520&action=review

Looks good.

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:294
> -        if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain)
> +        if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain)

I think we need a comment to explain why we are rejecting changes to ExclusivelyFromMainDocumentDomain but not to OnlyFromMainDocumentDomain: OnlyFromMainDocumentDomain is the default behavior when running layout tests, we have a couple tests that depend on it, and OnlyFromMainDocumentDomain cannot be set by public API users so they'll never notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200704/f72efc98/attachment.htm>