[Webkit-unassigned] [Bug 149496] [GTK] Use mobile user-agent on tablet

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 4 01:41:04 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=149496

--- Comment #19 from Jan-Michael Brummer <jan.brummer at tabos.org> ---
(In reply to Michael Catanzaro from comment #17)
> Comment on attachment 403492 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403492&action=review
> 
> OK, this is looking better, but it's still written too much like C code
> rather than C++, so I will try to show you how to fix that.

Thanks, yes a decade ago i used to write C++ and now it's C all the time. :)

> Will you also open a flatpak pull request to expose /etc/machine-info?

Sure, i promised it and will do it today.

Patch is updated based on your comments and i've splitted the second function into two for better readability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200704/730d0197/attachment.htm>


More information about the webkit-unassigned mailing list