[Webkit-unassigned] [Bug 213867] Crash in +[UIViewController _viewControllerForFullScreenPresentationFromView:] when WKContentView is deallocated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213867

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #403374|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 403374
  --> https://bugs.webkit.org/attachment.cgi?id=403374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403374&action=review

> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:287
> +    RetainPtr<WKContentView> view = _view.get();
> +    if (view)

OK as is. But could write this:

    if (RetainPtr<WKContentView> view = _view.get())

or this:

    if (auto view = retainPtr(_view.get()))

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200702/8bd1b744/attachment-0001.htm>