[Webkit-unassigned] [Bug 213885] [GTK] Crash in WebKit::DropTarget::didPerformAction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213885

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org> ---
The problem is that m_operation is not engaged (i.e. is not set), that causes the Optional to RELEASE_ASSERT() when it is dereferenced.

I haven't looked at this long enough to know if it's correct, but:

    if ((!operation && !m_operation) || *operation == *m_operation)

The crash would surely not occur if this was an || check:

    if (!operation || !m_operation || *operation == *m_operation)

That said, it looks like m_operation is not needed at all in the GTK 3 case. It can probably just be removed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200702/142c5a89/attachment.htm>