[Webkit-unassigned] [Bug 213888] New: [MSE][GStreamer] Don't skip samples past media duration in AppendPipeline
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 2 09:19:37 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=213888
Bug ID: 213888
Summary: [MSE][GStreamer] Don't skip samples past media
duration in AppendPipeline
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebKitGTK
Assignee: webkit-unassigned at lists.webkit.org
Reporter: aboya at igalia.com
CC: bugs-noreply at webkitgtk.org
appsinkNewSample() contained code to skip samples whose presentation
time starts after media duration. This is paradoxical, because later
sourceBufferPrivateDidReceiveSample() extends media duration whenever
the presentation end time of the sample is past the original one.
It does not sound reasonable that samples extending the duration are
okay on one case but outright rejected in the other. Also, if it was
about skipping samples, sourceBufferPrivateDidReceiveSample() could do
it itself, and already does in other cases.
For all these reasons I was very doubtful of the need for this if()
and indeed removing this condition didn't cause any new test failure.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200702/8a36f89c/attachment.htm>
More information about the webkit-unassigned
mailing list