[Webkit-unassigned] [Bug 207007] Add GPU Process support for accessLog et al.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207007

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 389268
  --> https://bugs.webkit.org/attachment.cgi?id=389268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389268&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:199
> +void RemoteMediaPlayerManagerProxy::updateVideoFullscreenInlineImage(MediaPlayerPrivateRemoteIdentifier id)

Please don't use 'id'. It will cause compile errors if this file is ever made a .mm file.

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:40
> +    AccessLog(WebKit::MediaPlayerPrivateRemoteIdentifier id) -> (String accessLog) Synchronous
> +    ErrorLog(WebKit::MediaPlayerPrivateRemoteIdentifier id) -> (String errorLog) Synchronous

no id

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:243
> +void RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage(void)

No need for void

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:530
> +    if (!connection().sendSync(Messages::RemoteMediaPlayerProxy::AccessLog(), Messages::RemoteMediaPlayerProxy::AccessLog::Reply(log), m_id))

Does this have to be synchronous IPC? We try to avoid that as much as possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200130/6790b60f/attachment-0001.htm>