[Webkit-unassigned] [Bug 206984] REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206984

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |youennf at gmail.com
 Attachment #389228|review?                     |review+
              Flags|                            |

--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 389228
  --> https://bugs.webkit.org/attachment.cgi?id=389228
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389228&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:618
> +        auto download = _session->networkProcess().downloadManager().download(_sessionWrapper->downloadMap.get(task.taskIdentifier));

There does not seem to be any guarantee that downloadMap will contain task.taskIdentifier.
If not, this would return 0 which could corrupt the DownloadManager map.
Can we add a check there, like done in URLSession:downloadTask:?

Also, I am wondering whether is it possible to create a test for it.
API tests can spin dedicated servers (look for ServiceWorkerTCPServer), not sure layout tests can pause/resume downloads though we could add test runner APIs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200130/19fcce6d/attachment-0001.htm>