[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 02:03:03 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #7 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 389232
  --> https://bugs.webkit.org/attachment.cgi?id=389232
Handling connections by one thread.

View in context: https://bugs.webkit.org/attachment.cgi?id=389232&action=review

> Source/WebCore/platform/network/curl/CurlStream.cpp:82
> +void CurlStream::send(UniqueArray<uint8_t>&& buffer, size_t length)

'length' is redundant. buffer has the size.

> Source/WebCore/platform/network/curl/CurlStream.cpp:191
> +void CurlStream::notifyFailWithError(CURLcode errorCode)

notifyFailWithError should be renamed because 'fail' is a verb, the phase 'notify fail' sounds weird.
I think you refereed 'curlDidFailWithError'. the phase 'did fail' is not weird.

> Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:172
> +    struct timeval timeout { 0, selectTimeoutMS * 1000};

You should implement self-piping technique here to wake up. (Bug 173449)
Then, you can sleep forever here instead of waking up every 20ms.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200130/ab1d9b04/attachment.htm>


More information about the webkit-unassigned mailing list