[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #28 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #23)
>  #if HAVE(OS_DARK_MODE_SUPPORT)
> -#if PLATFORM(COCOA)
> -    static const auto cssValueControlBackground =
> CSSValueAppleSystemControlBackground;
> -#else
> -    static const auto cssValueControlBackground = CSSValueWindow;
> -#endif
> -    Color baseBackgroundColor =
> backgroundColor.valueOr(RenderTheme::singleton().
> systemColor(cssValueControlBackground, styleColorOptions()));
> +    Color baseBackgroundColor =
> backgroundColor.valueOr(RenderTheme::singleton().
> systemColor(CSSValueAppleSystemControlBackground, styleColorOptions()));
>  #else
>      Color baseBackgroundColor = backgroundColor.valueOr(Color::white);
>  #endif
> 
> This reverts changes made in r244635, so now we always use white. Please,
> check OS_DARK_MODE_SUPPORT is not defined in your build.

Just to confirm, you are testing Cassidy's example https://cassidyjames.com/dark-demo/ with Adwaita Dark and you and you are seeing a white background on that page? Testing again with a clean build, it's definitely dark here. It doesn't make any sense why we would see different behavior in a basic test like this.

And it doesn't matter whether my build defines OS_DARK_MODE_SUPPORT because after your change, that is only ever used in *.mm files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200129/faeafe50/attachment.htm>