[Webkit-unassigned] [Bug 206831] [css-grid] Move grid-item-alignment tests to WPT folder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 08:47:22 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206831

--- Comment #9 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 389131
  --> https://bugs.webkit.org/attachment.cgi?id=389131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389131&action=review

>>> LayoutTests/imported/w3c/ChangeLog:11
>>> +        Imported to WPT with Chromium CL https://chromium-review.googlesource.com/c/chromium/src/+/2022793
>> 
>> nitpick: this should mention the WPT commit (not the Chromium CL). I guess its https://github.com/web-platform-tests/wpt/commit/b628488204 ?
> 
> The PR you mention here is related to other css tests, already reimported to WebKit.
> The tests contained in this patch, instead, have been directly imported with the Chromium CL, without a previous PR to WPT. Is there a better way I could rephrase this?

Yeah, it seems I got the wrong commit :)
I guess including the link to the WPT PR from to chromium CL would be nice. 
Is this one https://github.com/web-platform-tests/wpt/pull/21440 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200129/57719998/attachment.htm>


More information about the webkit-unassigned mailing list