[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 07:23:05 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #26 from Michael Catanzaro <mcatanzaro at gnome.org> ---
It occurs to me that there is one thing Cassidy's examples don't check: the color-scheme CSS property (formerly supported-color-schemes). Now, we can't support that until the distant future arrives, once we have an HTML theme that doesn't depend on GTK.

If that is set by the website, then we should draw form controls using the OS's dark theme. I think. Cassidy, any chance you have time to investigate this further, in a new bug report? It would be helpful to have a fourth test case that makes use of color-schemes and does not use prefers-color-scheme at all, and maybe a fifth that uses both. Does that make sense?

(In reply to Carlos Garcia Campos from comment #23)
> This reverts changes made in r244635, so now we always use white. Please,
> check OS_DARK_MODE_SUPPORT is not defined in your build.

I will check. It doesn't seem likely, but I don't know how else to explain hte difference in behavior we are seeing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200129/e2e9ee30/attachment.htm>


More information about the webkit-unassigned mailing list