[Webkit-unassigned] [Bug 206099] Null deref crash in DOMWindow::scrollBy after evoking updateLayoutIgnorePendingStylesheets()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206099

--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 389063
  --> https://bugs.webkit.org/attachment.cgi?id=389063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389063&action=review

> Source/WebCore/ChangeLog:3
> +        Deploy Ref and RefPtr in DOMWindow::scroll* functions

This line should be updated to reflect the new bug title.

> Source/WebCore/ChangeLog:9
> +        Added null pointer check for frame in scrollBy function before usage.
> +        Test: fast/dom/Window/window-scroll-ignore-null-frame.html

Nit: There should be a blank line between the description & Test: ~ line.

> LayoutTests/ChangeLog:3
> +        Deploy Ref and RefPtr in DOMWindow::scroll* functions

Ditto about updating this line.

> LayoutTests/ChangeLog:8
> +        Addedd null pointer check for frame in scrollBy, before using.

This description should be describing what we're doing in LayoutTests directory.
In this case, you're only adding a test case so it's sufficient to say: Added a regression test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/8b66198f/attachment.htm>