[Webkit-unassigned] [Bug 206107] Nullptr crash in WebCore::findPlaceForCounter with display: contents sibling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 27 23:12:14 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206107

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #388953|review?                     |review+
              Flags|                            |

--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388953
  --> https://bugs.webkit.org/attachment.cgi?id=388953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388953&action=review

> Source/WebCore/rendering/RenderCounter.cpp:80
> +    Element* previous = ElementTraversal::pseudoAwarePreviousSibling(*element);

Could be auto*

> Source/WebCore/rendering/RenderCounter.cpp:87
> +    RenderElement* renderer = element->renderer();

auto*

> Source/WebCore/rendering/RenderCounter.cpp:90
> +    if (renderer && renderer->isPseudoElement()) {
> +        return renderer->generatingElement();
>      }

WebKit coding style doesn't use { } around single line blocks.

> Source/WebCore/rendering/RenderCounter.cpp:104
> +    Element* previous = previousSiblingOrParentElement(renderer.element());

auto*

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/941ad015/attachment.htm>


More information about the webkit-unassigned mailing list