[Webkit-unassigned] [Bug 206099] Deploy Ref and RefPtr in DOMWindow::scroll* functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 27 21:51:56 PST 2020


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #388966|review?                     |review-
              Flags|                            |

--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 388966
  --> https://bugs.webkit.org/attachment.cgi?id=388966

View in context: https://bugs.webkit.org/attachment.cgi?id=388966&action=review

r- due to the following issues.

> Source/WebCore/ChangeLog:3
> +        Deploy Ref and RefPtr in DOMWindow::scroll* functions

The title of this bug doesn’t match your patch at all. Please fix it.

> Source/WebCore/ChangeLog:8
> +        Added Null pointer check for frame in scrollBy function before usage.

Nit: null pointer check, not Null pointer check.

> Source/WebCore/page/DOMWindow.cpp:1690
> +    FrameView* view = frame->view();

We should store FrameView in RefPtr. Use auto & makeRefPtr.

> LayoutTests/platform/mac/fast/dom/Window/window-scroll-ignore-null-frame-expected.txt:1
> +layer at (0,0) size 800x600

Please call dumpAsText in the test and add a platform agnostic result.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/9edcfa17/attachment.htm>

More information about the webkit-unassigned mailing list