[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #17 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #16)
> Then we need to revert the change from bug #196685 and have
> PageClientImpl::effectiveAppearanceIsDark always return false. And then we
> can close this bug, and all related dark mode bugs.

Carlos, are you OK with this proposal? It requires rolling out r244766.

(In reply to Adrian Perez from comment #12)
>  * If the theme name is “<name>-dark”:
>     - Remove the “-dark” suffix, use “<name>” as the theme.
>     - If the theme “<name>” does not exist, GTK automatically
>       fall-back to Adwaita.
>  * Otherwise:
>     - Keep the current theme name, assuming that it is light.

Let's do this too. I guess the RenderTheme::singleton() constructor in RenderThemeGtk.cpp would be a good place. Only other place I can think of that might be appropriate would be WebProcessMainGtk.cpp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/885694c8/attachment.htm>