[Webkit-unassigned] [Bug 202194] REGRESSION(r244635): [GTK] White text on white background in 2.26 when using dark GTK theme breaks Evolution and Geary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202194

--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #3)
> But perhaps another reasonable solution would be: if the text color is not
> specified, then use the theme text color only if the text is being displayed
> on the default background, otherwise use black if the background has been
> set (to anything other than the default theme background). Problem is, I
> don't know how to implement that, and I don't know whether that would be
> easy or really hard.

It's been five minutes and I'm already regretting having suggested this. It's a can of worms. We should just revert r244635 and press ahead on forcing light mode in bug #198947. There is just no chance that dark mode is *ever* going to work with web content that's not expecting it. We're causing all these theme problems by forcing it regardless of whether color-schemes is set, and trying to fix individual problems here and there without regressing other web content is not going to be successful. If we looked for the color-schemes property before using the dark theme, then we'd know the web content is prepared to handle dark mode with light default text color and dark background color. Otherwise, it's just not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/3b0eb50b/attachment.htm>