[Webkit-unassigned] [Bug 206705] Crash in RenderElement::selectionPseudoStyle with detail element set to display: contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206705

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 388888
  --> https://bugs.webkit.org/attachment.cgi?id=388888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388888&action=review

> Source/WebCore/rendering/RenderElement.cpp:1419
> +            // If an Element hasDisplayContents(), it will not have a renderer.
> +            // Instead, we must walk up the tree to find a parent element with a valid renderer.

This comment more or less repeats what the code says.
I'd try giving more of a why comment like this:
// When an element has display: contents, this element doesn't have a renderer
// and its children will render as children of the parent element.

There is no need to say that we're looking for the first element without display: contents
since that's pretty self explanatory from the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200127/119776a3/attachment.htm>