[Webkit-unassigned] [Bug 203789] Copying reference files on WPT import breaks when ref files contain references to support files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203789

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com

--- Comment #1 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
The WPT test importer detects this and does a rewrite of the relative URL when importing the ref-test.

The tag '<img class="green" src="../support/green.png">' should get updated to '<img class="green" src="support/green.png">' on the generated -expected.html.

Maybe it didn't work for you because the script doesn't do this rewrite if you import from a local source directory.

Example, if you do:

Tools/Scripts/import-w3c-tests -v -s /home/user/local-wpt-checkout css/css-backgrounds -d /home/user/WebKit/LayoutTests/imported/w3c/web-platform-tests

Then it don't do any rewrite

But if you do if you run it like:

Tools/Scripts/import-w3c-tests -t web-platform-tests/css/css-background

Then it will do the rewrites.

TIP: pass also the flag "-v" so you can see if it does the rewrites and if there is any WARNING doing that.

The logic it uses for that seems to be here:

https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/w3c/test_importer.py?rev=255074#L467


It does a rewrite of the URLs pointed by url(), href= or src= inside <style> tags as well as inside this list of tags: https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/w3c/test_converter.py?rev=255074#L222


In any case I also think we should fix bug 203784 and stop doing rewrites.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200127/8d1ce6db/attachment-0001.htm>