[Webkit-unassigned] [Bug 206724] Nullptr crash when setting custom properties on detached style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 26 21:33:17 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206724

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 388631
  --> https://bugs.webkit.org/attachment.cgi?id=388631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388631&action=review

> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:260
> +        ASSERT(document);

Why is this assertion safe? Since m_lastDocument is a WeakPtr, what guarantees it won’t be null?

> Source/WebCore/css/PropertySetCSSStyleDeclaration.h:63
> +    WeakPtr<Document> m_lastDocument;

This doesn’t seem like the right approach to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200127/eeb11bdd/attachment.htm>


More information about the webkit-unassigned mailing list