[Webkit-unassigned] [Bug 180913] [GTK] Fix compilation failures for a Release build with assertions turned on

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 25 23:44:37 PST 2020


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
 Attachment #329602|                            |review-
              Flags|                            |

--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 329602
  --> https://bugs.webkit.org/attachment.cgi?id=329602
fix NDEBUG conditionals for a Release build with assertions turned on

This is exactly the wrong thing to do.  The right thing to do is to find those fields which are needed for the ASSERT but are guarded by #if !NDEBUGand change them to be guarded by #if ASSERT_ENABLED because they are relevant to the assertion, and not a debug build per se.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200126/121154f3/attachment.htm>

More information about the webkit-unassigned mailing list