[Webkit-unassigned] [Bug 186971] Media player does not properly inhibit, uninhibit sleep

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186971

--- Comment #11 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Philippe Normand from comment #6)
> I started debugging this again.
> 
> In shouldDisableSleep(), both hasVideo() and hasAudio() calls return false
> because a null MediaPlayerPrivate has been created meanwhile. I don't know
> why yet... So this shouldn't happen, the video is paused and should have
> both audio and video... So shouldBeAbleToSleep becomes true there, instead
> of false.

I wasted a bunch of time debugging this today because I didn't read your comment. Conclusion: this is exactly what's still happening. When starting a YouTube video, m_mediaPlayer is either valid and paused() (during a brief window before playback begins), or else it's NULL (it seems to always be NULL during media playback). So next question to debug is: why is media playing when MediaPlayer is NULL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200125/eef820a0/attachment.htm>