[Webkit-unassigned] [Bug 206572] KeyedDecoderGeneric crashes when it accesses a data with empty string key.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206572

--- Comment #10 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #8)
> Comment on attachment 388524 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388524&action=review
> 
> > Source/WebCore/platform/generic/KeyedDecoderGeneric.cpp:61
> > +        result = emptyString();
> 
> I think if String::fromUTF8 is failed, a null string and false should be
> returned.
> 
> Of course, an empty string should be return for size == 0 case.
> 
> WDTY?

I agree. Failing fromUTF8 means decoded string is collapsed.
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200123/027b98f1/attachment.htm>