[Webkit-unassigned] [Bug 206389] It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206389

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #388447|review?                     |review+
              Flags|                            |

--- Comment #18 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 388447
  --> https://bugs.webkit.org/attachment.cgi?id=388447
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388447&action=review

I guess we should simplify things to stop using ASAN_ variables then!

> Tools/Scripts/webkitdirs.pm:908
> +    # treats errors as non-fatal when it encounters missing symbols related to coverage

Please add a period at the end of the sentence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200122/431447a1/attachment.htm>