[Webkit-unassigned] [Bug 191306] Automatic link replacement via "Smart links" should emit "insertLink" input events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 21 15:14:34 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=191306

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 388344 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388344&action=review
> 
> >> LayoutTests/fast/events/emit-insertLink-expected.txt:18
> >> +PASS successfullyParsed is true
> > 
> > Hm...I would've expected to see a line that says `event.inputType = insertLink` here too, instead of just insertText and insertParagraph.
> 
> Ah, you might need this:
> 
> if (window.internals)
>     internals.setAutomaticLinkDetectionEnabled(true);

...regrettably, this doesn't work in WebKit2; this is a known issue, currently being tracked by <webkit.org/b/162081>.

We could probably make the test work on WebKit2 as a followup in <webkit.org/b/162081>, and only enable in on WebKit1 for the time being.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200121/26f8a56d/attachment-0001.htm>


More information about the webkit-unassigned mailing list