[Webkit-unassigned] [Bug 206537] DLLLauncherMain print to console instead of opening window on fatal error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206537

Ross Kirsling <ross.kirsling at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ross.kirsling at sony.com

--- Comment #6 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 388305
  --> https://bugs.webkit.org/attachment.cgi?id=388305
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388305&action=review

Nice! I hadn't thought of this approach.

Can you also apply this change to the other copy of DLLLauncherMain (which we use for all executables other than JSC shell)?
https://github.com/WebKit/webkit/blob/master/Tools/win/DLLLauncher/DLLLauncherMain.cpp

> Source/JavaScriptCore/shell/DLLLauncherMain.cpp:113
> +    fprintf(stderr, "%s %s\n", caption.c_str(), message.c_str());

Our Windows code uses wide-character strings, so let's do this:

    fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str());

> Source/JavaScriptCore/shell/DLLLauncherMain.cpp:114
> +    exit(1);

This shouldn't be necessary; whatever is calling this should just exit with the returned 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200121/f2184d57/attachment-0001.htm>