[Webkit-unassigned] [Bug 206389] It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206389

--- Comment #11 from Tuomas Karkkainen <tuomas.webkit at apple.com> ---
(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 388000 [details]
> proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388000&action=review
> 
> 
> > Tools/Scripts/run-javascriptcore-tests:662
> > +    unshift @command, "xcrun", "llvm-profdata", "merge", @profrawFiles, "-o", $profdataPath;
> 
> Is it OK to always use the default toolchain? I suspect that we'll run into
> an issue sooner or later without --sdk or --toolchain. I'm concerned about
> embedded targets and about internal builds.
> 
> Same comment about every xcrun invocation.

Should xcrun be replaced with xcrun --sdk macosx ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200121/d2cdb08b/attachment.htm>