[Webkit-unassigned] [Bug 206392] [GTK][WPE] Websockets close-on-x tests are failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 21 06:22:23 PST 2020


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |cgarcia at igalia.com
            Summary|[GTK] Websockets close-on-x |[GTK][WPE] Websockets
                   |tests are failing           |close-on-x tests are
                   |                            |failing

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
This "regressed" in https://gitlab.gnome.org/GNOME/libsoup/commit/35f1bac5ff9ec694e64b65e51f0e7a3226aa3aaf

but I don't think the new behavior in libsoup is wrong. Those tests only work on messages are sent asynchronously, so what happened before was that close messages was queued to be sent, then the connection was closed and the output source stopped so the close message was never sent. Now we don't wait for the output to be available to send message, we just try and only in case of would block error we wait for the output source to be available. So, in those tests the close message is sent before the connection is closed. I've tried with ff and chrome and I get the same results (same failure), so I think we can just rebaseline those tests for GTK and WPE.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200121/3be6f9f2/attachment.htm>

More information about the webkit-unassigned mailing list