[Webkit-unassigned] [Bug 206505] New: Fix missing header guards and clean up empty files in WebCore, WebKitLegacy, WebKit, Tools

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 20 09:27:41 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206505

            Bug ID: 206505
           Summary: Fix missing header guards and clean up empty files in
                    WebCore, WebKitLegacy, WebKit, Tools
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org

Fix missing header guards and clean up empty files in WebCore, WebKitLegacy, WebKit, Tools.

See Bug 206480 Comment #6 for WebCore, WebKitLegacy, WebKit.

Here are the Tools directories I checked:

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/header_guard_missing Tools/DumpRenderTree Tools/WebKitTestRunner Tools/TestRunnerShared Tools/TestWebKitAPI
ERROR: Tools/DumpRenderTree/win/resource.h:5:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:3:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:3:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:3:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:3:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/TestWebKitAPI/JavaScriptTest.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp"
ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:20:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/DFAHelpers.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
Total errors found: 9 in 1735 files

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200120/e2e329ca/attachment.htm>


More information about the webkit-unassigned mailing list