[Webkit-unassigned] [Bug 206481] New: Fix missing header guards and clean up empty files in bmalloc, WTF, JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206481

            Bug ID: 206481
           Summary: Fix missing header guards and clean up empty files in
                    bmalloc, WTF, JavaScriptCore
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: keith_miller at apple.com, mark.lam at apple.com

Fix missing header guards and clean up empty files in bmalloc, WTF, JavaScriptCore.

Bug 206480 improves check-webkit-style to do a better job at finding missing header guards in non-Objective-C files:

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/header_guard_missing Source/bmalloc
ERROR: Source/bmalloc/bmalloc/ScopeExit.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
Total errors found: 1 in 142 files

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/header_guard_missing Source/WTF
ERROR: Source/WTF/wtf/win/PathWalker.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/WTF/wtf/cocoa/Entitlements.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
Total errors found: 2 in 800 files

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/header_guard_missing Source/JavaScriptCore
ERROR: Source/JavaScriptCore/dfg/DFGPrePostNumbering.h:2:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/JavaScriptCore/b3/testb3.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/JavaScriptCore/JavaScriptCore.vcxproj/resource.h:5:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/JavaScriptCore/wasm/WasmGeneratorTraits.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/JavaScriptCore/runtime/OptionEntry.h:2:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
ERROR: Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:27:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCWrapperMap.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCException.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCAutocleanups.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCOptions.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCCallbackFunction.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCDefines.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCContext.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCClass.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCWeakValue.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCGLibWrapperObject.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCValue.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/jsc.h"
WARNING: File exempt from style guide. Skipping: "Source/JavaScriptCore/API/glib/JSCVirtualMachine.h"
ERROR: Source/JavaScriptCore/heap/IsoInlinedHeapCellType.h:26:  Missing #pragma once for header guard.  [build/header_guard_missing] [5]
Total errors found: 7 in 3153 files

To find empty files, use:

$ find [path] -size 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200119/2b7f07f7/attachment.htm>