[Webkit-unassigned] [Bug 206480] New: check-webkit-style: Improve header guard checks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 18 22:17:33 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206480

            Bug ID: 206480
           Summary: check-webkit-style: Improve header guard checks
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: achristensen at apple.com, keith_miller at apple.com,
                    thorton at apple.com

Improve header guard checks in check-webkit-style.

Bug 206448 demonstrated that the header guard checks in check-webkit-style would not warn about new header files that were missing "#pragma once" statements because it assumed that any header file that didn't already have an #ifndef/#define/#endif check _might_ be an Objective-C header that didn't need a header guard.

We can do better than this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200119/084aab01/attachment-0001.htm>


More information about the webkit-unassigned mailing list