[Webkit-unassigned] [Bug 206033] Standard gamepad mapping for GameControllerGamepads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206033

--- Comment #14 from James Howard <jameshoward at mac.com> ---
> Please remove this statement.

And replace it with this?

#if HAVE(GCEXTENDEDGAMEPAD_BUTTONS_THUMBSTICK)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunguarded-availability"
    if ([m_extendedGamepad.get() respondsToSelector:@selector(leftThumbstickButton)]) {
        bindButton(m_extendedGamepad.get().leftThumbstickButton, 10);
        bindButton(m_extendedGamepad.get().rightThumbstickButton, 11);
    }
#pragma clang diagnostic pop
#endif


Our options are disable the unguarded-availability warning or use @available. We can't set the HAVE_ flag to __MAC_OS_X_VERSION_MIN_REQUIRED >= 101401 since the Mojave build has it set to 101400, which means it would be compiled out incorrectly there, and also WebKit style check won't allow a point release in a HAVE_ flag.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200116/acff28ce/attachment.htm>