[Webkit-unassigned] [Bug 206364] Make the callAsyncJavaScriptFunction function actually be async (so await works)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206364

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 387938
  --> https://bugs.webkit.org/attachment.cgi?id=387938
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387938&action=review

> Source/WebCore/bindings/js/ScriptController.cpp:607
> +    functionStringBuilder.append("(async function(");

One issue with making a function `async` is that they _always_ return a `Promise`.  I think it would be better to have `ScriptController:callInWorld` take an `enum class IsAsync { Yes, No };` so that callers can decide whether or not they want this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200116/bd956dee/attachment.htm>