[Webkit-unassigned] [Bug 206204] Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206204

--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 387706
  --> https://bugs.webkit.org/attachment.cgi?id=387706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387706&action=review

> LayoutTests/loader/change-src-during-iframe-load-crash.html:3
> +function load() {

The issue is that in WebKit1, this event handler runs after eventhandler3 had finished running.
The solution is to add a flag which eventhandler3 set, and only call waitUntilDone when the flag isn't set like this:

let didLoad = false;
let didFinishTesting = false;

function load() {
    document.body.innerHTML = 'The test is declared pass if there is no crash observed.';
    didLoad = true;
    if (window.testRunner) {
        testRunner.dumpAsText();
        if (!didFinishTesting)
            testRunner.waitUntilDone();
    }
}

function eventhandler3() {
    iframe1.srcdoc = "x";
    didFinishTesting = true;
    if (window.testRunner && didLoad)
        testRunner.notifyDone();
}

> LayoutTests/loader/change-src-during-iframe-load-crash.html:11
> +function eventhandler3() {

Can we rename this event handler to something more sensible like didLoadFrame2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200116/c1658a28/attachment.htm>