[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 15 11:42:01 PST 2020
https://bugs.webkit.org/show_bug.cgi?id=176119
--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 387812
--> https://bugs.webkit.org/attachment.cgi?id=387812
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=387812&action=review
> Source/WebKit/ChangeLog:10
> + No new tests (OOPS!).
A basic API test would check the default value, change it, then get it again and verify that it's actually changed. Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp would be a good place.
> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:3141
> + * Returns: %TRUE% if @web_view audio is muted or %FALSE% is audio is not muted.
% goes only before, not after, TRUE and FALSE
> Source/WebKit/UIProcess/WebPageProxy.h:1263
> + bool getMuted();
Should be const, and code style is to avoid "get":
bool isMuted() const;
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200115/2b624439/attachment.htm>
More information about the webkit-unassigned
mailing list