[Webkit-unassigned] [Bug 205902] KeyedDecoderGeneric crashes when it accesses data with non-existing key

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 13 18:43:16 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=205902

--- Comment #9 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #4)
> Comment on attachment 387078 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387078&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/KeyedCodingGeneric.cpp:108
> > +    encoder->encodeInt32("int32-max", INT32_MAX);
> 
> I think you can simplify these tests by add a template function.
> 
> testSimpleValue(&WebCore::KeyedEncoder::encodeInt64,
> &WebCore::KeyedDecoder::decodeInt64, -2);
> testSimpleValue(&WebCore::KeyedEncoder::encodeFloat,
> &WebCore::KeyedDecoder::decodeFloat, -1.5);

Added template function testSimpleValue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200114/07ee7bf1/attachment-0001.htm>


More information about the webkit-unassigned mailing list