[Webkit-unassigned] [Bug 206190] New: Enable -Wconditional-uninitialized in bmalloc, WTF, JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206190

            Bug ID: 206190
           Summary: Enable -Wconditional-uninitialized in bmalloc, WTF,
                    JavaScriptCore
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: mark.lam at apple.com

Enable -Wconditional-uninitialized in bmalloc, WTF, JavaScriptCore.

Neither bmalloc nor WTF have any warnings.

This fixes the following warnings in JavaScriptCore:


Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3428:24: error: variable 'continuation' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
            m_out.jump(continuation);
                       ^~~~~~~~~~~~
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3411:33: note: initialize the variable 'continuation' to silence this warning
        LBasicBlock continuation;
                                ^
                                 = nullptr
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3429:42: error: variable 'lastNext' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
            m_out.appendTo(continuation, lastNext);
                                         ^~~~~~~~
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3412:29: note: initialize the variable 'lastNext' to silence this warning
        LBasicBlock lastNext;
                            ^
                             = nullptr
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13299:44: error: variable 'globalObject' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
            patchpoint->appendSomeRegister(globalObject);
                                           ^~~~~~~~~~~~
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13288:28: note: initialize the variable 'globalObject' to silence this warning
        LValue globalObject;
                           ^
                            = nullptr
3 errors generated.


In file included from Release/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource63.cpp:1:
./ftl/FTLThunks.cpp:170:28: error: variable 'someGPR' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
        jit.move64ToDouble(someGPR, reg.fpr());
                           ^~~~~~~
./ftl/FTLThunks.cpp:157:5: note: variable 'someGPR' is declared here
    GPRReg someGPR;
    ^
1 error generated.


In file included from Release/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource137.cpp:8:
./wasm/js/WebAssemblyTablePrototype.cpp:145:35: error: variable 'wasmWrapperFunction' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
                table->set(index, wasmWrapperFunction);
                                  ^~~~~~~~~~~~~~~~~~~
./wasm/js/WebAssemblyTablePrototype.cpp:133:56: note: initialize the variable 'wasmWrapperFunction' to silence this warning
        WebAssemblyWrapperFunction* wasmWrapperFunction;
                                                       ^
                                                        = nullptr
./wasm/js/WebAssemblyTablePrototype.cpp:142:17: error: variable 'wasmFunction' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
            if (wasmFunction)
                ^~~~~~~~~~~~
./wasm/js/WebAssemblyTablePrototype.cpp:132:42: note: initialize the variable 'wasmFunction' to silence this warning
        WebAssemblyFunction* wasmFunction;
                                         ^
                                          = nullptr
2 errors generated.


Source/JavaScriptCore/b3/testb3_4.cpp:870:36: error: variable 'arg' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
    CHECK(compileAndRun<int>(proc, arg) == 8675309);
                                   ^~~
In file included from Source/JavaScriptCore/b3/testb3_4.cpp:27:
Source/JavaScriptCore/b3/testb3.h:106:12: note: expanded from macro 'CHECK'
    if (!!(x))                                                      \
           ^
Source/JavaScriptCore/b3/testb3_4.cpp:851:18: note: initialize the variable 'arg' to silence this warning
    uintptr_t arg;
                 ^
                  = 0
Source/JavaScriptCore/b3/testb3_4.cpp:859:6: error: variable 'slot' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
    *slot = 8675309;
     ^~~~
Source/JavaScriptCore/b3/testb3_4.cpp:850:14: note: initialize the variable 'slot' to silence this warning
    int* slot;
             ^
              = nullptr
2 errors generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200113/ac41677d/attachment-0001.htm>