[Webkit-unassigned] [Bug 206166] scanSideState scans too much side state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206166

--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 387551 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387551&action=review
> 
> r=me too with comment.
> Who is initializing CheckpointOSRExitSideState tmps? Are all elements
> cleared (JSEmpty) when declaring it? Can we add default initializer to
> `tmps` field as,
> 
> JSValue tmps[maxNumCheckpointTmps] { };

Currently, no one. I can do that though.

> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        JSC: Crash during GC
> 
> Let's rename the title.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200113/542a83ee/attachment.htm>