[Webkit-unassigned] [Bug 206167] WK1 DumpRenderTree doesn't support enabling and disabling features in test header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206167

--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
(In reply to Antti Koivisto from comment #11)
> > Maybe we're not talking about the same thing. TestOptions do not just work
> > in WKTR, they require code to support them. The code in DRT and WKTR to
> > support TestOptions is similar although it is slightly more annoying in DRT
> > because you need code for 2 ports.
> 
> We must indeed be talking about different thing. There is zero code in WKTR
> to support LayoutFormattingContextIntegrationEnabled flag for example, yet
> it works beautifully.

Oh, I see:
<!-- webkit-test-runner [ internal:LayoutFormattingContextIntegrationEnabled=true ] -->

vs

<!-- webkit-test-runner [ enableBackForwardCache=true ] -->

We're *almost* talking about the same thing. It's just that there is a special "internal:" prefix that maps nicely to internal settings in WK2. Those indeed do not require any new code in WKTR. Then again, I don't think we have the concept of internal/experimental feature in WK1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200113/920075c7/attachment.htm>