[Webkit-unassigned] [Bug 206099] Deploy Ref and RefPtr in DOMWindow::scroll* functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 13 08:45:04 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206099

--- Comment #8 from Jack <shihchieh_lee at apple.com> ---
Thanks! Will either keep this line or add reference count to prevent frame being deleted.

(In reply to Chris Dumez from comment #5)
> Comment on attachment 387396 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387396&action=review
> 
> > Source/WebCore/page/DOMWindow.cpp:1604
> > +    if (!frame)
> 
> This is a bogus check. if (!isCurrentlyDisplayedInFrame()) would have
> returned early above if the frame was null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200113/c105957f/attachment-0001.htm>


More information about the webkit-unassigned mailing list