[Webkit-unassigned] [Bug 205801] Streaming aac/mp3 audio doesn't always work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 13 02:40:55 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=205801

--- Comment #8 from Philippe Normand <pnormand at igalia.com> ---
I can reproduce the bug, the problem is that our httpsrc element quickly assumes those live stream have a content-length, hence EOS is pushed too early and playback stops :(

This works-around the bug, but might introduce other layout test failures, so it should be properly investigated:

diff --git a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
index 3dae81aa68d..6be6193ffd1 100644
--- a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
+++ b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
@@ -1171,10 +1171,10 @@ void CachedResourceStreamingClient::dataReceived(PlatformMediaResource&, const c
     if (priv->haveSize && (newPosition > priv->size)) {
         GST_DEBUG_OBJECT(src, "Got position previous estimated content size (%" G_GINT64_FORMAT " > %" G_GINT64_FORMAT ")", newPosition, priv->size);
         newSize = newPosition;
-    } else if (!priv->haveSize) {
-        GST_DEBUG_OBJECT(src, "Got initial response without Content-Length, assuming response size as duration.");
-        newSize = length;
-        priv->haveSize = true;
+    // } else if (!priv->haveSize) {
+    //     GST_DEBUG_OBJECT(src, "Got initial response without Content-Length, assuming response size as duration.");
+    //     newSize = length;
+    //     priv->haveSize = true;
     }

     if (newSize) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200113/5635a7c5/attachment-0001.htm>


More information about the webkit-unassigned mailing list