[Webkit-unassigned] [Bug 205617] Add makeRefCounted<>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205617

--- Comment #12 from Geoffrey Garen <ggaren at apple.com> ---
(In reply to Antti Koivisto from comment #8)
> (In reply to Anders Carlsson from comment #6)
> > It seems like stack-allocating RefCounted would already ASSERT on
> > destruction due to the m_adoptionIsRequired checks in place.
> 
> Good point!

In addition to the ASSERT, a tool can tell us "you called new / constructor on a RefCounted object" -- and we are working to enforce other RefCounted rules that way.

I wonder if makeRefCounted can eventually take care of declaring and creating the refcount too, removing the need to inherit from RefCounted. In theory, it might be just fine to stack-allocate, unique-allocate, or refptr-allocate an object, depending on how you use it. (One option would be for makeRefCounted to allocate a RefCountWrapper<T> type, rather than T, where RefCountWrapper<T> inherited from RefCounted<T> and T.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200109/3747296a/attachment.htm>