[Webkit-unassigned] [Bug 206019] Setting currentScale to non-finite values should throw TypeError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206019

Said Abou-Hallawa <sabouhallawa at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #387247|review?                     |review+
              Flags|                            |

--- Comment #3 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 387247
  --> https://bugs.webkit.org/attachment.cgi?id=387247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387247&action=review

> Source/WebCore/ChangeLog:6
> +        Align SVGElement currentScale definition to SVG2 section 5.14.2.

Please add a link to the specs: https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSVGElement.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:15
> +    svgvar.currentScale = 1.0;
> +    shouldBe('svgvar.currentScale', '1.0')

Maybe you need to add semicolon at the end each statement just for consistency.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:46
> +        testFailed('set currentScale to Infinity without error')

svgvar.currentScale is set to character 'a' not Infinity.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:49
> +            testPassed('set currentScale to Infinity throws TypeError')

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200109/f0e42d43/attachment.htm>