[Webkit-unassigned] [Bug 205958] Web Inspector: awaitPromise option in Runtime.evaluate and Runtime.callFunctionOn

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205958

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dino at apple.com

--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387140
  --> https://bugs.webkit.org/attachment.cgi?id=387140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387140&action=review

> Source/JavaScriptCore/inspector/InjectedScriptSource.js:186
> +            callback("Could not find object with given id");
> +            return;

Don't you want to reject the promise here?

> Source/JavaScriptCore/inspector/InjectedScriptSource.js:197
> +                    callback(String(e));
> +                    return;

And here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200109/50797e3e/attachment.htm>