[Webkit-unassigned] [Bug 205902] KeyedDecoderGeneric craches when it acesses data with non-existing key.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205902

--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 387078
  --> https://bugs.webkit.org/attachment.cgi?id=387078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387078&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/KeyedCodingGeneric.cpp:108
>> +    encoder->encodeInt32("int32-max", INT32_MAX);
> 
> I think you can simplify these tests by add a template function.
> 
> testSimpleValue(&WebCore::KeyedEncoder::encodeInt64, &WebCore::KeyedDecoder::decodeInt64, -2);
> testSimpleValue(&WebCore::KeyedEncoder::encodeFloat, &WebCore::KeyedDecoder::decodeFloat, -1.5);

But, I am wondering round trip tests are really needed because it transfers the encoding and decoding tasks to PersistentEncoder.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200108/b3826568/attachment.htm>