[Webkit-unassigned] [Bug 205756] REGRESSION: [ Mac ] webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 4 14:56:41 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=205756

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kbr at google.com

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
The confusion is because matching -expected.txt is not always the same as passing a test.

> I'm now very confused. I did revert this test to what it was before the ANGLE default.

This is not accurate. Here is the full history.

1. Before ANGLE was enabled, the test was passing on most hardware, and had a passing -expected.txt checked in. It was failing on several models though:

iMacPro1,1
MacPro7,1
MacBookPro10,1
MacBookPro11,3
MacBookPro9,1

These are the oldest and newest AMD based devices. 

2. When ANGLE got enabled, the test started to pass everywhere, and you didn't change -expected.txt.

3. When ANGLE got rolled back, you also landed -expected.txt with failing results.

Did you generate your new results on an iMac Pro?

> I don't think it is worth investigating this. We're moving to ANGLE where it doesn't reproduce.

This is correct. Thank you for updating TestExpectations. It would be even better to roll back -expected.txt to a PASS, as that's the IG behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200104/c857b83d/attachment-0001.htm>


More information about the webkit-unassigned mailing list