[Webkit-unassigned] [Bug 203620] [SOUP] HSTS Support causes page loading to fail with "Operation was cancelled"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203620

--- Comment #18 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 386681
  --> https://bugs.webkit.org/attachment.cgi?id=386681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386681&action=review

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:310
>      RefPtr<NetworkDataTaskSoup> protectedThis = adoptRef(task);

Maybe we should do a global search to see if we have more places where the words "protected" or "protector" and "adopt" appear on the same line. Seems that will almost always indicate either a misnamed variable or, potentially, a bug. If it really *was* a protector (no adopt), then your change would have been fine as-is. I think you got tricked by the incorrect name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200104/34fe2b4a/attachment.htm>