[Webkit-unassigned] [Bug 205282] Missing tests on r253521

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205282

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #22 from Darin Adler <darin at apple.com> ---
Comment on attachment 386028
  --> https://bugs.webkit.org/attachment.cgi?id=386028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386028&action=review

> Source/WebCore/ChangeLog:3
> +        Fix missing tests from bug 205217

I don’t understand this bug title. It doesn’t "fix missing tests"; it seems to fix a bug and add a test.

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:70
> +    if (!parent.element() || !parent.element()->isSVGElement())

Should write:

    if (!is<SVGElement>(parent.element()))

That combines the null check with the type check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200104/2b42c0a0/attachment.htm>